linux-kernel - Re: [ANNOUNCE] work tree for untorn filesystem writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pln9sl2y.fsf@gmail.com>
Date: Tue, 05 Nov 2024 21:56:45 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: "Darrick J. Wong" <djwong@...nel.org>, John Garry <john.g.garry@...cle.com>, brauner@...nel.org, Catherine Hoang <catherine.hoang@...cle.com>
Cc: linux-ext4@...r.kernel.org, Theodore Ts'o <tytso@....edu>, Jan Kara <jack@...e.cz>, Christoph Hellwig <hch@...radead.org>, Ojaswin Mujoo <ojaswin@...ux.ibm.com>, linux-block@...r.kernel.org, Dave Chinner <david@...morbit.com>, linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [ANNOUNCE] work tree for untorn filesystem writes

"Darrick J. Wong" <djwong@...nel.org> writes:

> Hi everyone,
>
> Nobody else has stepped up to do this, so I've created a work branch for
> the fs side of untorn writes:
> https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=fs-atomic_2024-11-04
>
> Can you all check this to make sure that I merged it correctly?

Sorry, I couldn't reply earlier(I am currently on travel). Yes, the ext4
merge looks correct to me. You have taken the latest v4 of the ext4
atomic write series [1]. 

[1]: https://lore.kernel.org/linux-ext4/cover.1730437365.git.ritesh.list@gmail.com/

> And maybe go test this on your storage hardware? :)

Due to limited connectivity during my travel, I don't have the access to
the hardware. But as I mentioned the merge looks correct to me and I had
tested those patches earlier on Power and x86.
But I will in general re-test the mentioned fs branch for both XFS and
ext4 once I reach back but I don't think we need to wait for that as the
merge looks good to me.

Also, I noticed that we might have missed to add a Tested-by from
Ojaswin for XFS series here [2]. Although Ojaswin mentioned that he
might also re-test the mentioned FS atomic write branch for both XFS and
EXT4.

[2]: https://lore.kernel.org/linux-xfs/Zxnp8bma2KrMDg5m@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com/

-ritesh

> If all goes well then I think the next step is to ask brauner very
> nicely if he'd consider adding this to the vfs trees for 6.13.  If not
> then I guess we can submit it ourselves, though we probably ought to ask
> rothwell to add the branch to for-next asap.
>
> PS: We're now past -rc6 so please reply quickly so that this doesn't
> slip yet another cycle.
>
> Catherine: John's on vacation all week, could you please send me the
> latest versions of the xfs_io pwrite-atomic patch and the fstest for it?
>
> --D