linux-kernel - Re: [PATCH v2 2/6] perf trace-event: Constify print arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZypTbPyzplDg1cf9@x1>
Date: Tue, 5 Nov 2024 14:18:36 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Athira Jajeev <atrajeev@...ux.vnet.ibm.com>,
	James Clark <james.clark@...aro.org>,
	Dominique Martinet <asmadeus@...ewreck.org>,
	Yang Li <yang.lee@...ux.alibaba.com>,
	Colin Ian King <colin.i.king@...il.com>,
	Yang Jihong <yangjihong@...edance.com>,
	"Steinar H. Gunderson" <sesse@...gle.com>,
	Oliver Upton <oliver.upton@...ux.dev>,
	Ilkka Koskinen <ilkka@...amperecomputing.com>,
	Ze Gao <zegao2021@...il.com>, Weilin Wang <weilin.wang@...el.com>,
	Ben Gainey <ben.gainey@....com>,
	zhaimingbing <zhaimingbing@...s.chinamobile.com>,
	Zixian Cai <fzczx123@...il.com>, Andi Kleen <ak@...ux.intel.com>,
	Paran Lee <p4ranlee@...il.com>,
	Thomas Falcon <thomas.falcon@...el.com>,
	linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
	"Steven Rostedt (Google)" <rostedt@...dmis.org>
Subject: Re: [PATCH v2 2/6] perf trace-event: Constify print arguments

On Sat, Nov 02, 2024 at 09:53:56AM -0700, Ian Rogers wrote:
> Capture that these functions don't mutate their input.

Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com>

- Arnaldo
 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/util/trace-event-parse.c | 4 ++--
>  tools/perf/util/trace-event.h       | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
> index f0332bd3a501..6f11ca5513e3 100644
> --- a/tools/perf/util/trace-event-parse.c
> +++ b/tools/perf/util/trace-event-parse.c
> @@ -99,7 +99,7 @@ unsigned long long read_size(struct tep_event *event, void *ptr, int size)
>  	return tep_read_number(event->tep, ptr, size);
>  }
>  
> -void event_format__fprintf(struct tep_event *event,
> +void event_format__fprintf(const struct tep_event *event,
>  			   int cpu, void *data, int size, FILE *fp)
>  {
>  	struct tep_record record;
> @@ -116,7 +116,7 @@ void event_format__fprintf(struct tep_event *event,
>  	trace_seq_destroy(&s);
>  }
>  
> -void event_format__print(struct tep_event *event,
> +void event_format__print(const struct tep_event *event,
>  			 int cpu, void *data, int size)
>  {
>  	return event_format__fprintf(event, cpu, data, size, stdout);
> diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h
> index bbf8b26bc8da..084068fb36a1 100644
> --- a/tools/perf/util/trace-event.h
> +++ b/tools/perf/util/trace-event.h
> @@ -39,10 +39,10 @@ trace_event__tp_format(const char *sys, const char *name);
>  
>  struct tep_event *trace_event__tp_format_id(int id);
>  
> -void event_format__fprintf(struct tep_event *event,
> +void event_format__fprintf(const struct tep_event *event,
>  			   int cpu, void *data, int size, FILE *fp);
>  
> -void event_format__print(struct tep_event *event,
> +void event_format__print(const struct tep_event *event,
>  			 int cpu, void *data, int size);
>  
>  int parse_ftrace_file(struct tep_handle *pevent, char *buf, unsigned long size);
> -- 
> 2.47.0.199.ga7371fff76-goog