linux-kernel - Re: [PATCH net-next v3 1/2] bnxt_en: ethtool: Remove ip4/ip6 ntuple support for IPPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLinN5zh-E5Oh+dupsECNT-07Gc8mXh8FrAkY3nbQbW7GhQ@mail.gmail.com>
Date: Tue, 5 Nov 2024 09:36:55 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: Daniel Xu <dxu@...uu.xyz>
Cc: andrew+netdev@...n.ch, edumazet@...gle.com, kuba@...nel.org, 
	davem@...emloft.net, pabeni@...hat.com, martin.lau@...ux.dev, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH net-next v3 1/2] bnxt_en: ethtool: Remove ip4/ip6 ntuple
 support for IPPROTO_RAW

On Mon, Nov 4, 2024 at 8:13 PM Daniel Xu <dxu@...uu.xyz> wrote:
>
> Commit 9ba0e56199e3 ("bnxt_en: Enhance ethtool ntuple support for ip
> flows besides TCP/UDP") added support for ip4/ip6 ntuple rules.
> However, if you wanted to wildcard over l4proto, you had to provide
> 0xFF.
>
> The choice of 0xFF is non-standard and non-intuitive. Delete support for
> it in this commit. Next commit we will introduce a cleaner way to
> wildcard l4proto.
>
> Signed-off-by: Daniel Xu <dxu@...uu.xyz>

Thanks.
Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)