linux-kernel - Re: [PATCH 1/5] asm-generic: add smp_vcond_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f46a71b5-8e0f-c2a9-b3f8-d499c10f227a@gentwo.org>
Date: Tue, 5 Nov 2024 11:36:25 -0800 (PST)
From: "Christoph Lameter (Ampere)" <cl@...two.org>
To: Haris Okanovic <harisokn@...zon.com>
cc: ankur.a.arora@...cle.com, catalin.marinas@....com, 
    linux-pm@...r.kernel.org, kvm@...r.kernel.org, 
    linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
    will@...nel.org, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, 
    dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com, 
    pbonzini@...hat.com, wanpengli@...cent.com, vkuznets@...hat.com, 
    rafael@...nel.org, daniel.lezcano@...aro.org, peterz@...radead.org, 
    arnd@...db.de, lenb@...nel.org, mark.rutland@....com, mtosatti@...hat.com, 
    sudeep.holla@....com, misono.tomohiro@...itsu.com, maobibo@...ngson.cn, 
    joao.m.martins@...cle.com, boris.ostrovsky@...cle.com, 
    konrad.wilk@...cle.com
Subject: Re: [PATCH 1/5] asm-generic: add smp_vcond_load_relaxed()

On Tue, 5 Nov 2024, Haris Okanovic wrote:

> +/**
> + * smp_vcond_load_relaxed() - (Spin) wait until an expected value at address
> + * with no ordering guarantees. Spins until `(*addr & mask) == val` or
> + * `nsecs` elapse, and returns the last observed `*addr` value.
> + *
> + * @nsecs: timeout in nanoseconds

Please use an absolute time in nsecs instead of a timeout. You do not know
what will happen to your execution thread until the local_clock_noinstr()
is run.