linux-kernel - Re: [PATCH] x86/cpufeature: Document cpu_feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44b38e7d-7dea-4e7b-9056-03a1ef5aac8a@intel.com>
Date: Tue, 5 Nov 2024 11:59:38 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Borislav Petkov <bp@...en8.de>, Sohil Mehta <sohil.mehta@...el.com>
Cc: Yazen Ghannam <yazen.ghannam@....com>, "Luck, Tony"
 <tony.luck@...el.com>, Andy Whitcroft <apw@...onical.com>,
 Joe Perches <joe@...ches.com>,
 "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "x86@...nel.org" <x86@...nel.org>,
 "avadhut.naik@....com" <avadhut.naik@....com>,
 "john.allen@....com" <john.allen@....com>,
 "mario.limonciello@....com" <mario.limonciello@....com>,
 "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
 "Shyam-sundar.S-k@....com" <Shyam-sundar.S-k@....com>,
 "richard.gong@....com" <richard.gong@....com>,
 "jdelvare@...e.com" <jdelvare@...e.com>,
 "linux@...ck-us.net" <linux@...ck-us.net>,
 "clemens@...isch.de" <clemens@...isch.de>,
 "hdegoede@...hat.com" <hdegoede@...hat.com>,
 "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
 "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
 "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
 "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>,
 "naveenkrishna.chatradhi@....com" <naveenkrishna.chatradhi@....com>,
 "carlos.bilbao.osdev@...il.com" <carlos.bilbao.osdev@...il.com>
Subject: Re: [PATCH] x86/cpufeature: Document cpu_feature_enabled() as the
 default to use

On 10/31/24 03:34, Borislav Petkov wrote:
> cpu_feature_enabled() should be used in most cases when CPU feature
> support needs to be tested in code. Document that.

Yes, please.  BTW, I know the code generation isn't great in some cases.
 But this is the right _way_ to call things no "boot_" or &boot_cpu_data
for system-wide things.  Underlying code generation can continue to be
fixed up over time.

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>