linux-kernel - Re: [PATCH] ACPI: thermal: Use strscpy instead of strcpy.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jrxW+MxES3CgiFG4ttJWtV85=j3CpyeeJqveDvNj=6fw@mail.gmail.com>
Date: Tue, 5 Nov 2024 21:22:50 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Muhammad Qasim Abdul Majeed <qasim.majeed20@...il.com>
Cc: rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: thermal: Use strscpy instead of strcpy.

On Sun, Oct 27, 2024 at 9:30 AM Muhammad Qasim Abdul Majeed
<qasim.majeed20@...il.com> wrote:
>
> Replace strcpy() with strscpy() in the ACPI thermal driver.
>
> strcpy() has been deprecated because it is generally unsafe.
> Eliminating it from the kernel source.
>
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@...il.com>
>
> Hi Rafael,
>
> Any update on the patches?
>
> Best Regards,
> Qasim
>
> ---
>  drivers/acpi/thermal.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index a0cfc857fb55..0c69d04fbac9 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -842,9 +842,9 @@ static int acpi_thermal_add(struct acpi_device *device)
>                 return -ENOMEM;
>
>         tz->device = device;
> -       strcpy(tz->name, device->pnp.bus_id);
> -       strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
> -       strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
> +       strscpy(tz->name, device->pnp.bus_id);
> +       strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
> +       strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
>         device->driver_data = tz;
>
>         acpi_thermal_aml_dependency_fix(tz);
> --

Applied (with edits in the changelog) as 6.13 material, thanks!