linux-kernel - Re: [PATCH] m68k: mvme147: Reinstate early console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d321d30f-df85-f6d8-69d4-4dfb68cb9b93@linux-m68k.org>
Date: Wed, 6 Nov 2024 10:17:17 +1100 (AEDT)
From: Finn Thain <fthain@...ux-m68k.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
cc: Daniel Palmer <daniel@...f.com>, stable@...nel.org, 
    linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: mvme147: Reinstate early console


On Tue, 5 Nov 2024, Geert Uytterhoeven wrote:

> > Cc: Daniel Palmer <daniel@...f.com>
> > Cc: stable@...nel.org
> > Fixes: a38eaa07a0ce ("m68k/mvme147: config.c - Remove unused functions")
> > Signed-off-by: Daniel Palmer <daniel@...f.com>
> > Reviewed-by: Finn Thain <fthain@...ux-m68k.org>
> 
> As this patch differs from Daniel's original, I guess you want
> 
>     Co-deloped-by: Daniel Palmer <daniel@...f.com>
>     Signed-off-by: Daniel Palmer <daniel@...f.com>
>     Co-deloped-by: Finn Thain <fthain@...ux-m68k.org>
>     Signed-off-by: Finn Thain <fthain@...ux-m68k.org>
> 
> instead?
> 

No problem.

> > --- a/arch/m68k/mvme147/config.c
> > +++ b/arch/m68k/mvme147/config.c
> > @@ -33,6 +33,7 @@
> >  #include <asm/mvme147hw.h>
> >  #include <asm/config.h>
> >
> > +#include "mvme147.h"
> >
> >  static void mvme147_get_model(char *model);
> >  extern void mvme147_sched_init(void);
> > @@ -177,3 +178,29 @@ static u64 mvme147_read_clk(struct clocksource *cs)
> >
> >         return ticks;
> >  }
> > +
> > +#define SCC_DELAY do { __asm__ __volatile__ ("nop; nop;"); } while (0)
> 
> Please keep on using a static (inline) function instead of a macro.
> 

Will do.

> > +
> > +static void scc_write(char ch)
> > +{
> > +       do {
> > +               SCC_DELAY;
> > +       } while (!(in_8(M147_SCC_A_ADDR) & BIT(2)));
> > +       SCC_DELAY;
> > +       out_8(M147_SCC_A_ADDR, 8);
> > +       SCC_DELAY;
> > +       out_8(M147_SCC_A_ADDR, ch);
> > +}
> 
> The rest LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> 

Thanks.