linux-kernel - Re: [PATCH v6 11/12] platform/x86/amd: hfi: Set ITMT priority from ranking data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZymwOJtr1k+6ZJGk@BLRRASHENOY1.amd.com>
Date: Tue, 5 Nov 2024 11:12:16 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@....com>
To: Mario Limonciello <mario.limonciello@....com>
Cc: Borislav Petkov <bp@...en8.de>, Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	x86@...nel.org, Perry Yuan <perry.yuan@....com>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-pm@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	Shyam Sundar S K <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH v6 11/12] platform/x86/amd: hfi: Set ITMT priority from
 ranking data

On Mon, Nov 04, 2024 at 11:54:06AM -0600, Mario Limonciello wrote:
> The static ranking data that is read at module load should be used
> to set up the priorities for the cores relative to the performance
> values.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Looks good to me.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@....com>

--
Thanks and Regards
gautham.

> ---
>  drivers/platform/x86/amd/hfi/Kconfig |  1 +
>  drivers/platform/x86/amd/hfi/hfi.c   | 10 ++++++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/hfi/Kconfig b/drivers/platform/x86/amd/hfi/Kconfig
> index 79e3b0073275c..5b7c2865f4aa9 100644
> --- a/drivers/platform/x86/amd/hfi/Kconfig
> +++ b/drivers/platform/x86/amd/hfi/Kconfig
> @@ -7,6 +7,7 @@ config AMD_HFI
>  	bool "AMD Hetero Core Hardware Feedback Driver"
>  	depends on ACPI
>  	depends on CPU_SUP_AMD
> +	depends on SCHED_MC_PRIO
>  	help
>  	 Select this option to enable the AMD Heterogeneous Core Hardware Feedback Interface. If
>  	 selected, hardware provides runtime thread classification guidance to the operating system
> diff --git a/drivers/platform/x86/amd/hfi/hfi.c b/drivers/platform/x86/amd/hfi/hfi.c
> index cef6aa84bd85e..09905a354efdd 100644
> --- a/drivers/platform/x86/amd/hfi/hfi.c
> +++ b/drivers/platform/x86/amd/hfi/hfi.c
> @@ -115,6 +115,12 @@ static DEFINE_PER_CPU(struct amd_hfi_cpuinfo, amd_hfi_cpuinfo) = {.class_index =
>  
>  static DEFINE_MUTEX(hfi_cpuinfo_lock);
>  
> +static void amd_hfi_sched_itmt_work(struct work_struct *work)
> +{
> +	sched_set_itmt_support();
> +}
> +static DECLARE_WORK(sched_amd_hfi_itmt_work, amd_hfi_sched_itmt_work);
> +
>  static int find_cpu_index_by_apicid(unsigned int target_apicid)
>  {
>  	int cpu_index;
> @@ -234,6 +240,8 @@ static int amd_set_hfi_ipcc_score(struct amd_hfi_cpuinfo *hfi_cpuinfo, int cpu)
>  		WRITE_ONCE(hfi_cpuinfo->ipcc_scores[i],
>  			   hfi_cpuinfo->amd_hfi_classes[i].perf);
>  
> +	sched_set_itmt_core_prio(hfi_cpuinfo->ipcc_scores[0], cpu);
> +
>  	return 0;
>  }
>  
> @@ -453,6 +461,8 @@ static int amd_hfi_probe(struct platform_device *pdev)
>  	if (ret < 0)
>  		return ret;
>  
> +	schedule_work(&sched_amd_hfi_itmt_work);
> +
>  	return 0;
>  }
>  
> -- 
> 2.43.0
>