linux-kernel - Re: [PATCH v3 2/6] block: Error an attempt to split an atomic write in bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aee733a2-96a3-488d-930c-c4c9c3661daf@suse.de>
Date: Tue, 5 Nov 2024 08:22:28 +0100
From: Hannes Reinecke <hare@...e.de>
To: John Garry <john.g.garry@...cle.com>, axboe@...nel.dk, song@...nel.org,
 yukuai3@...wei.com, hch@....de
Cc: martin.petersen@...cle.com, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
 Johannes.Thumshirn@....com
Subject: Re: [PATCH v3 2/6] block: Error an attempt to split an atomic write
 in bio_split()

On 10/31/24 10:59, John Garry wrote:
> This is disallowed.
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>
> Signed-off-by: John Garry <john.g.garry@...cle.com>
> ---
>   block/bio.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/block/bio.c b/block/bio.c
> index 7a93724e4a49..07b971853768 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -1749,6 +1749,10 @@ struct bio *bio_split(struct bio *bio, int sectors,
>   	if (WARN_ON_ONCE(bio_op(bio) == REQ_OP_ZONE_APPEND))
>   		return ERR_PTR(-EINVAL);
>   
> +	/* atomic writes cannot be split */
> +	if (bio->bi_opf & REQ_ATOMIC)
> +		return ERR_PTR(-EINVAL);
> +
>   	split = bio_alloc_clone(bio->bi_bdev, bio, gfp, bs);
>   	if (!split)
>   		return ERR_PTR(-ENOMEM);

Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich