[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <74c84937-fa12-4ab2-922b-7889eb5dda47@kernel.org>
Date: Tue, 5 Nov 2024 08:24:55 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>, ath12k@...ts.infradead.org
Cc: linux-wireless@...r.kernel.org, Kalle Valo <kvalo@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [RFC PATCH v2 1/5] dt-bindings: net: wireless: ath12k: describe
WSI properties for QCN9274
On 04/11/2024 19:44, Raj Kumar Bhagat wrote:
>>> $id: http://devicetree.org/schemas/net/wireless/qcom,ath12k.yaml#
>>> @@ -18,10 +19,17 @@ properties:
>>> compatible:
>>> enum:
>>> - pci17cb,1107 # WCN7850
>>> + - pci17cb,1109 # QCN9274
>>
>> I asked for separate binding because it is quite a different device.
>> Unless it is not... but then commit msg is quite not precise here.
>>
>
> sure, will create a separate binding, may be "qcom,ath12k_wsi.yaml".
Underscores are not allowed in compatibles and the file name follows
compatible name, so use hyphen.
>>> + type: object
>>> + description: |
>>> + The ath12k devices (QCN9274) feature WSI support. WSI stands for
>>> + WLAN Serial Interface. It is used for the exchange of specific
>>> + control information across radios based on the doorbell mechanism.
>>> + This WSI connection is essential to exchange control information
>>> + among these devices.
>>> +
>>> + Diagram to represent one WSI connection (one WSI group) among
>>> + three devices.
>>> +
>>> + +-------+ +-------+ +-------+
>>> + | pcie2 | | pcie3 | | pcie1 |
>>> + | | | | | |
>>> + +----->| wsi |------->| wsi |------->| wsi |-----+
>>> + | | grp 0 | | grp 0 | | grp 2 | |
>>> + | +-------+ +-------+ +-------+ |
>>> + +------------------------------------------------------+
>>> +
>>> + Diagram to represent two WSI connections (two separate WSI groups)
>>> + among four devices.
>>> +
>>> + +-------+ +-------+ +-------+ +-------+
>>> + | pcie2 | | pcie3 | | pcie1 | | pcie0 |
>>> + | | | | | | | |
>>> + +-->| wsi |--->| wsi |--+ +-->| wsi |--->| wsi |--+
>>> + | | grp 0 | | grp 0 | | | | grp 1 | | grp 1 | |
>>> + | +-------+ +-------+ | | +-------+ +-------+ |
>>> + +---------------------------+ +---------------------------+
>>> +
>>> + properties:
>>> + qcom,wsi-group-id:
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + description:
>>> + It represents the identifier assigned to the WSI connection. All
>>> + the ath12k devices connected to same WSI connection have the
>>> + same wsi-group-id.
>>
>> That's not needed according to description. Entire group is defined by
>> graph.
>>
>
> So this mean "qcom,wsi-group-id" to be dropped and we can assign the
> group ID (in ath12k driver implementation) by using the graph?
Yes
>
Best regards,
Krzysztof
Powered by blists - more mailing lists