linux-kernel - Re: [Linux-stm32] [PATCH] irqchip/stm32mp-exti: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <008a261f5407ab38bb025768624bdc6bd1869c84.camel@foss.st.com>
Date: Tue, 5 Nov 2024 09:23:43 +0100
From: Antonio Borneo <antonio.borneo@...s.st.com>
To: "Rob Herring (Arm)" <robh@...nel.org>,
        Thomas Gleixner
	<tglx@...utronix.de>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre
 Torgue <alexandre.torgue@...s.st.com>
CC: <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [Linux-stm32] [PATCH] irqchip/stm32mp-exti: Use
 of_property_present() for non-boolean properties

On Mon, 2024-11-04 at 13:08 -0600, Rob Herring (Arm) wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  drivers/irqchip/irq-stm32mp-exti.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c
> index 33e0cfdea654..cb83d6cc6113 100644
> --- a/drivers/irqchip/irq-stm32mp-exti.c
> +++ b/drivers/irqchip/irq-stm32mp-exti.c
> @@ -696,8 +696,7 @@ static int stm32mp_exti_probe(struct platform_device *pdev)
>         if (ret)
>                 return ret;
>  
> -       if (of_property_read_bool(np, "interrupts-extended"))
> -               host_data->dt_has_irqs_desc = true;
> +       host_data->dt_has_irqs_desc = of_property_present(np, "interrupts-extended");
>  
>         return 0;
>  }

Reviewed-by: Antonio Borneo <antonio.borneo@...s.st.com>

Thanks,
Antonio