linux-kernel - Re: [PATCH v2] tools/hv: terminate fcopy daemon if read from uio fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241105083834.GA8168@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Tue, 5 Nov 2024 00:38:34 -0800
From: Saurabh Singh Sengar <ssengar@...ux.microsoft.com>
To: Olaf Hering <olaf@...fle.de>
Cc: linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>
Subject: Re: [PATCH v2] tools/hv: terminate fcopy daemon if read from uio
 fails

On Tue, Nov 05, 2024 at 09:14:04AM +0100, Olaf Hering wrote:
> Terminate endless loop in reading fails, to avoid flooding syslog.
> 
> This happens if the state of "Guest services" integration service
> is changed from "enabled" to "disabled" at runtime in the VM
> settings. In this case pread returns EIO.

My comment on V1 was meant to log this information in the syslog, so the
user can look for the Guest Service status incase of EIO. Capturing these
details in the commit will require additional effort from user.

Nevertheless, thanks for fixing this:

Reviewed-by: Saurabh Sengar <ssengar@...ux.microsoft.com>

> 
> Also handle an interrupted system call, and continue in this case.
> 
> Signed-off-by: Olaf Hering <olaf@...fle.de>
> ---
> v2: update commit message
> 
> A more complete fix is to handle this properly in the kernel,
> by making the file descriptor unavailable for further operations.
> 
>  tools/hv/hv_fcopy_uio_daemon.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/hv/hv_fcopy_uio_daemon.c b/tools/hv/hv_fcopy_uio_daemon.c
> index 7a00f3066a98..281fd95dc0d8 100644
> --- a/tools/hv/hv_fcopy_uio_daemon.c
> +++ b/tools/hv/hv_fcopy_uio_daemon.c
> @@ -468,8 +468,10 @@ int main(int argc, char *argv[])
>  		 */
>  		ret = pread(fcopy_fd, &tmp, sizeof(int), 0);
>  		if (ret < 0) {
> +			if (errno == EINTR || errno == EAGAIN)
> +				continue;
>  			syslog(LOG_ERR, "pread failed: %s", strerror(errno));
> -			continue;
> +			goto close;
>  		}
>  
>  		len = HV_RING_SIZE;