linux-kernel - Re: [PATCH v2] PCI: endpoint: Remove surplus return statement from pci_epf_test_clean_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241105091902.GB2202146@rocinante>
Date: Tue, 5 Nov 2024 18:19:02 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: 2564278112@...com
Cc: manivannan.sadhasivam@...aro.org, kishon@...nel.org,
	bhelgaas@...gle.com, cassel@...nel.org, Frank.Li@....com,
	dlemoal@...nel.org, jiangwang@...inos.cn, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PCI: endpoint: Remove surplus return statement from
 pci_epf_test_clean_dma_chan()

Hello,

> Remove a surplus return statement from the void function that has been
> added in the commit commit 8353813c88ef ("PCI: endpoint: Enable DMA
> tests for endpoints with DMA capabilities").
> 
> Especially, as an empty return statements at the end of a void functions
> serve little purpose.
> 
> Otherwise, a warning will be issued when building the kernel with W=1:
> 
>   296: FILE: ./drivers/pci/endpoint/functions/pci-epf-test.c:296:
>   return;

Applied to endpoint, thank you!

[01/01] PCI: endpoint: Remove surplus return statement from pci_epf_test_clean_dma_chan()
        https://git.kernel.org/pci/pci/c/06f893055382

        Krzysztof