linux-kernel - Re: [PATCH RFC net-next v2 07/18] net: ethtool: Add support for ethnl_info_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241105103749.0fe5a3a0@kmaincent-XPS-13-7390>
Date: Tue, 5 Nov 2024 10:37:49 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
 <corbet@....net>, Donald Hunter <donald.hunter@...il.com>, Rob Herring
 <robh@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman
 <horms@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
 <broonie@...nel.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>, Dent
 Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime
 Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH RFC net-next v2 07/18] net: ethtool: Add support for
 ethnl_info_init_ntf helper function

On Thu, 31 Oct 2024 22:44:51 +0100
Andrew Lunn <andrew@...n.ch> wrote:

> On Wed, Oct 30, 2024 at 05:53:09PM +0100, Kory Maincent wrote:
> > From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> > 
> > Introduce support for the ethnl_info_init_ntf helper function to enable
> > initialization of ethtool notifications outside of the netlink.c file.
> > This change allows for more flexible notification handling.
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> > ---
> > 
> > changes in v2:
> > - new patch.
> > ---
> >  net/ethtool/netlink.c | 5 +++++
> >  net/ethtool/netlink.h | 2 ++
> >  2 files changed, 7 insertions(+)
> > 
> > diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c
> > index e3f0ef6b851b..808cc8096f93 100644
> > --- a/net/ethtool/netlink.c
> > +++ b/net/ethtool/netlink.c
> > @@ -805,6 +805,11 @@ static void ethnl_default_notify(struct net_device
> > *dev, unsigned int cmd, typedef void (*ethnl_notify_handler_t)(struct
> > net_device *dev, unsigned int cmd, const void *data);
> >  
> > +void ethnl_info_init_ntf(struct genl_info *info, u8 cmd)
> > +{
> > +	genl_info_init_ntf(info, &ethtool_genl_family, cmd);
> > +}
> > +  
> 
> I've not looked at the users yet. Does this need EXPORT_SYMBOL_GPL()?

No it doesn't as the user is net/ethtool/pse-pd.c

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com