linux-kernel - Re: [RESEND PATCH] ext4: Annotate struct fname with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <0323DE8F-A0F4-4396-A755-41CE1DCC6A48@linux.dev>
Date: Tue, 5 Nov 2024 11:17:24 +0100
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Theodore Ts'o <tytso@....edu>,
 Andreas Dilger <adilger.kernel@...ger.ca>,
 Kees Cook <kees@...nel.org>,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Jan Kara <jack@...e.cz>,
 linux-ext4@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [RESEND PATCH] ext4: Annotate struct fname with __counted_by()

On 5. Nov 2024, at 10:52, Greg KH wrote:
> On Tue, Nov 05, 2024 at 12:42:14AM +0100, Thorsten Blum wrote:
>> Add the __counted_by compiler attribute to the flexible array member
>> name to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
>> CONFIG_FORTIFY_SOURCE.
>> 
>> Inline and use struct_size() to calculate the number of bytes to
>> allocate for new_fn and remove the local variable len.
> 
> This is two different things, why not do this in two different patches?
> 
> thanks,
> 
> greg k-h

No particular reason. I'll submit a v2 for the __counted_by() annotation
and a separate patch for struct_size().

I'll keep Jan's Reviewed-by: tag for both.

Thanks,
Thorsten