linux-kernel - Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes to async flip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpoEEo5tB00Yqoi7V2U=pRud1W44W3V8bJnr3N468EhQOw@mail.gmail.com>
Date: Tue, 5 Nov 2024 10:51:11 +0000
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Christopher Snowhill <chris@...e54.net>
Cc: André Almeida <andrealmeid@...lia.com>, 
	kernel-dev@...lia.com, Simon Ser <contact@...rsion.fr>, 
	Thomas Zimmermann <tzimmermann@...e.de>, joshua@...ggi.es, ville.syrjala@...ux.intel.com, 
	Daniel Stone <daniel@...ishbar.org>, Xaver Hugl <xaver.hugl@...il.com>, 
	Harry Wentland <harry.wentland@....com>, Simona Vetter <simona@...ll.ch>, 
	Alex Deucher <alexander.deucher@....com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	amd-gfx@...ts.freedesktop.org, Leo Li <sunpeng.li@....com>, 
	Christian König <christian.koenig@....com>, 
	David Airlie <airlied@...il.com>, Rodrigo Siqueira <Rodrigo.Siqueira@....com>, 
	Xinhui Pan <Xinhui.Pan@....com>
Subject: Re: [PATCH RESEND v9 1/2] drm/atomic: Let drivers decide which planes
 to async flip

On Tue, 5 Nov 2024 at 10:15, Christopher Snowhill <chris@...e54.net> wrote:
>
> On Mon Nov 4, 2024 at 12:52 PM PST, André Almeida wrote:
> > Hi Christopher,
> >
> > Em 03/11/2024 03:36, Christopher Snowhill escreveu:
> > > On Fri Nov 1, 2024 at 11:23 AM PDT, André Almeida wrote:
> > >> Currently, DRM atomic uAPI allows only primary planes to be flipped
> > >> asynchronously. However, each driver might be able to perform async
> > >> flips in other different plane types. To enable drivers to set their own
> > >> restrictions on which type of plane they can or cannot flip, use the
> > >> existing atomic_async_check() from struct drm_plane_helper_funcs to
> > >> enhance this flexibility, thus allowing different plane types to be able
> > >> to do async flips as well.
> > >>
> > >> In order to prevent regressions and such, we keep the current policy: we
> > >> skip the driver check for the primary plane, because it is always
> > >> allowed to do async flips on it.
> > >>
> > >> Signed-off-by: André Almeida <andrealmeid@...lia.com>
> > >
> > > Should I do a R-b too?
> >
> > If you can review the code, it's always really appreciated.
>
> I mean, I did review your changes, they looked good to me. I just didn't
> know the protocol for reporting review in addition to testing.

Please respond with the R-B tag. Also ideally the Tested-by should
contain the reference to a platform which was used to test it.

>
> >
> > > The changes looked sound enough for me to feel
> > > like testing it as well. Tested Borderlands Game of the Year Enhanced on
> > > my RX 7700 XT at maximum settings at 1080p165, and the tearing support in
> > > labwc allowed it to reach over 700fps. No problems from the hardware
> > > cursor.
> >
> > Thanks for testing and reporting!
> >
> > >
> > > Tested-by: Christopher Snowhill <chris@...e54.net>
> > >
>


-- 
With best wishes
Dmitry