[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <62773e8f-884c-4bfe-b412-97ad976f9cb8@redhat.com>
Date: Tue, 5 Nov 2024 12:22:35 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
horms@...nel.org, dsahern@...nel.org, pablo@...filter.org,
kadlec@...filter.org, roopa@...dia.com, razor@...ckwall.org,
gnault@...hat.com, bigeasy@...utronix.de, hawk@...nel.org,
idosch@...dia.com, dongml2@...natelecom.cn, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
coreteam@...filter.org, bridge@...ts.linux.dev, bpf@...r.kernel.org
Subject: Re: [PATCH RESEND net-next v4 6/9] net: ip: make
ip_route_input_noref() return drop reasons
Hi,
On 10/30/24 02:41, Menglong Dong wrote:
> @@ -175,10 +175,12 @@ static void ip_expire(struct timer_list *t)
>
> /* skb has no dst, perform route lookup again */
> iph = ip_hdr(head);
> - err = ip_route_input_noref(head, iph->daddr, iph->saddr, ip4h_dscp(iph),
> - head->dev);
> - if (err)
> + reason = ip_route_input_noref(head, iph->daddr, iph->saddr,
> + ip4h_dscp(iph), head->dev);
> + if (reason)
> goto out;
> + else
> + reason = SKB_DROP_REASON_FRAG_REASM_TIMEOUT;
I think the else branch above is confusing - and unneeded.
Please move the assignment after the comment below, so it's clear why we
get a TIMEOUT drop reason.
Thanks,
Paolo
Powered by blists - more mailing lists