[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <78cdcdc4-8087-449d-b771-e41e6295137f@rivosinc.com>
Date: Tue, 5 Nov 2024 13:48:35 +0100
From: Clément Léger <cleger@...osinc.com>
To: "Rob Herring (Arm)" <robh@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
<palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: cacheinfo: Use of_property_present() for
non-boolean properties
On 04/11/2024 20:03, Rob Herring (Arm) wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
> arch/riscv/kernel/cacheinfo.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/riscv/kernel/cacheinfo.c b/arch/riscv/kernel/cacheinfo.c
> index b320b1d9aa01..0115051fa1e1 100644
> --- a/arch/riscv/kernel/cacheinfo.c
> +++ b/arch/riscv/kernel/cacheinfo.c
> @@ -105,11 +105,11 @@ int populate_cache_leaves(unsigned int cpu)
> return 0;
> }
>
> - if (of_property_read_bool(np, "cache-size"))
> + if (of_property_present(np, "cache-size"))
> ci_leaf_init(this_leaf++, CACHE_TYPE_UNIFIED, level);
> - if (of_property_read_bool(np, "i-cache-size"))
> + if (of_property_present(np, "i-cache-size"))
> ci_leaf_init(this_leaf++, CACHE_TYPE_INST, level);
> - if (of_property_read_bool(np, "d-cache-size"))
> + if (of_property_present(np, "d-cache-size"))
> ci_leaf_init(this_leaf++, CACHE_TYPE_DATA, level);
>
> prev = np;
> @@ -122,11 +122,11 @@ int populate_cache_leaves(unsigned int cpu)
> break;
> if (level <= levels)
> break;
> - if (of_property_read_bool(np, "cache-size"))
> + if (of_property_present(np, "cache-size"))
> ci_leaf_init(this_leaf++, CACHE_TYPE_UNIFIED, level);
> - if (of_property_read_bool(np, "i-cache-size"))
> + if (of_property_present(np, "i-cache-size"))
> ci_leaf_init(this_leaf++, CACHE_TYPE_INST, level);
> - if (of_property_read_bool(np, "d-cache-size"))
> + if (of_property_present(np, "d-cache-size"))
> ci_leaf_init(this_leaf++, CACHE_TYPE_DATA, level);
> levels = level;
> }
Looks good to me,
Reviewed-by: Clément Léger <cleger@...osinc.com>
Thanks,
Clément
Powered by blists - more mailing lists