linux-kernel - Re: [PATCH] misc: atmel-ssc: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b297a3e-d59e-4768-b482-8ed15d79c220@microchip.com>
Date: Tue, 5 Nov 2024 12:53:18 +0000
From: <Hari.PrasathGE@...rochip.com>
To: <robh@...nel.org>, <claudiu.beznea@...on.dev>, <arnd@...db.de>,
	<gregkh@...uxfoundation.org>, <Nicolas.Ferre@...rochip.com>,
	<alexandre.belloni@...tlin.com>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] misc: atmel-ssc: Use of_property_present() for
 non-boolean properties



On 11/5/24 12:36 AM, Rob Herring (Arm) wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
> 

Thank you for the patch.

Reviewed-by: Hari Prasath Gujulan Elango <hari.prasathge@...rochip.com>

> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>   drivers/misc/atmel-ssc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 6eac0f335915..1d0322dfaf79 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -153,7 +153,7 @@ static int ssc_sound_dai_probe(struct ssc_device *ssc)
> 
>          ssc->sound_dai = false;
> 
> -       if (!of_property_read_bool(np, "#sound-dai-cells"))
> +       if (!of_property_present(np, "#sound-dai-cells"))
>                  return 0;
> 
>          id = of_alias_get_id(np, "ssc");
> @@ -176,7 +176,7 @@ static void ssc_sound_dai_remove(struct ssc_device *ssc)
>   #else
>   static inline int ssc_sound_dai_probe(struct ssc_device *ssc)
>   {
> -       if (of_property_read_bool(ssc->pdev->dev.of_node, "#sound-dai-cells"))
> +       if (of_property_present(ssc->pdev->dev.of_node, "#sound-dai-cells"))
>                  return -ENOTSUPP;
> 
>          return 0;
> --
> 2.45.2
> 
>