linux-kernel - Re: [PATCH] tty: atmel_serial: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241105133155.67025-1-andrei.simion@microchip.com>
Date: Tue, 5 Nov 2024 15:31:56 +0200
From: Andrei Simion <andrei.simion@...rochip.com>
To: <mihai.sain@...rochip.com>
CC: <alexandre.belloni@...tlin.com>, <claudiu.beznea@...on.dev>,
	<gregkh@...uxfoundation.org>, <hari.prasathge@...rochip.com>,
	<jirislaby@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
	<nicolas.ferre@...rochip.com>, <richard.genoud@...tlin.com>, Andrei Simion
	<andrei.simion@...rochip.com>
Subject: Re: [PATCH] tty: atmel_serial: Use devm_platform_ioremap_resource()

On 05.11.2024 15:19, Mihai Sain wrote:
> Simplify the request port function by using a single call
> to devm_platform_ioremap_resource().
> 
> This will also enhance the printing from /proc/iomem:
> 
> cat /proc/iomem | grep flexcom ; cat /proc/iomem | grep serial
> 
> f0004000-f00041ff : f0004000.flexcom flexcom@...04000
> f8020000-f80201ff : f8020000.flexcom flexcom@...20000
> f0004200-f00043ff : f0004200.serial serial@200
> f8020200-f80203ff : f8020200.serial serial@200
> fffff200-fffff3ff : fffff200.serial serial@...ff200
> 
> Signed-off-by: Mihai Sain <mihai.sain@...rochip.com>

Hi,

Tested-by: Andrei Simion <andrei.simion@...rochip.com>

Best Regards,
Andrei

> ---
>  drivers/tty/serial/atmel_serial.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 09b246c9e389..e1107f14ec98 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -2419,17 +2419,11 @@ static void atmel_release_port(struct uart_port *port)
>  static int atmel_request_port(struct uart_port *port)
>  {
>  	struct platform_device *mpdev = to_platform_device(port->dev->parent);
> -	int size = resource_size(mpdev->resource);
> -
> -	if (!request_mem_region(port->mapbase, size, "atmel_serial"))
> -		return -EBUSY;
>  
>  	if (port->flags & UPF_IOREMAP) {
> -		port->membase = ioremap(port->mapbase, size);
> -		if (port->membase == NULL) {
> -			release_mem_region(port->mapbase, size);
> -			return -ENOMEM;
> -		}
> +		port->membase = devm_platform_ioremap_resource(mpdev, 0);
> +		if (IS_ERR(port->membase))
> +			return PTR_ERR(port->membase);
>  	}
>  
>  	return 0;
> 
> base-commit: 2e1b3cc9d7f790145a80cb705b168f05dab65df2