linux-kernel - Re: [PATCH 2/2] iio: adc: vf610_adc: limit i.MX6SX's channel number to 4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202411052136.jstxD0iJ-lkp@intel.com>
Date: Tue, 5 Nov 2024 21:53:25 +0800
From: kernel test robot <lkp@...el.com>
To: Frank Li <Frank.Li@....com>, Haibo Chen <haibo.chen@....com>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"open list:NXP i.MX 7D/6SX/6UL/93 AND VF610 ADC DRIVER" <linux-iio@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH 2/2] iio: adc: vf610_adc: limit i.MX6SX's channel number
 to 4

Hi Frank,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on next-20241105]
[cannot apply to linus/master v6.12-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Frank-Li/iio-adc-vf610_adc-limit-i-MX6SX-s-channel-number-to-4/20241105-071339
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20241104231200.2745342-2-Frank.Li%40nxp.com
patch subject: [PATCH 2/2] iio: adc: vf610_adc: limit i.MX6SX's channel number to 4
config: alpha-randconfig-r072-20241105 (https://download.01.org/0day-ci/archive/20241105/202411052136.jstxD0iJ-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241105/202411052136.jstxD0iJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411052136.jstxD0iJ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/iio/adc/vf610_adc.c: In function 'vf610_adc_probe':
>> drivers/iio/adc/vf610_adc.c:874:35: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     874 |         indio_dev->num_channels = (u32)device_get_match_data(dev);
         |                                   ^


vim +874 drivers/iio/adc/vf610_adc.c

   817	
   818	static int vf610_adc_probe(struct platform_device *pdev)
   819	{
   820		struct device *dev = &pdev->dev;
   821		struct vf610_adc *info;
   822		struct iio_dev *indio_dev;
   823		int irq;
   824		int ret;
   825	
   826		indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(struct vf610_adc));
   827		if (!indio_dev)
   828			return dev_err_probe(&pdev->dev, -ENOMEM, "Failed allocating iio device\n");
   829	
   830		info = iio_priv(indio_dev);
   831		info->dev = &pdev->dev;
   832	
   833		info->regs = devm_platform_ioremap_resource(pdev, 0);
   834		if (IS_ERR(info->regs))
   835			return PTR_ERR(info->regs);
   836	
   837		irq = platform_get_irq(pdev, 0);
   838		if (irq < 0)
   839			return irq;
   840	
   841		ret = devm_request_irq(info->dev, irq,
   842					vf610_adc_isr, 0,
   843					dev_name(&pdev->dev), indio_dev);
   844		if (ret < 0)
   845			dev_err_probe(&pdev->dev, ret, "failed requesting irq, irq = %d\n", irq);
   846	
   847		info->clk = devm_clk_get_enabled(&pdev->dev, "adc");
   848		if (IS_ERR(info->clk))
   849			return dev_err_probe(&pdev->dev, PTR_ERR(info->clk),
   850					     "failed getting clock, err = %ld\n",
   851					     PTR_ERR(info->clk));
   852	
   853		info->vref = devm_regulator_get(&pdev->dev, "vref");
   854		if (IS_ERR(info->vref))
   855			return PTR_ERR(info->vref);
   856	
   857		info->vref_uv = devm_regulator_get_enable_read_voltage(&pdev->dev, "vref");
   858		if (info->vref_uv < 0)
   859			return info->vref_uv;
   860	
   861		device_property_read_u32_array(dev, "fsl,adck-max-frequency", info->max_adck_rate, 3);
   862	
   863		info->adc_feature.default_sample_time = DEFAULT_SAMPLE_TIME;
   864		device_property_read_u32(dev, "min-sample-time", &info->adc_feature.default_sample_time);
   865	
   866		platform_set_drvdata(pdev, indio_dev);
   867	
   868		init_completion(&info->completion);
   869	
   870		indio_dev->name = dev_name(&pdev->dev);
   871		indio_dev->info = &vf610_adc_iio_info;
   872		indio_dev->modes = INDIO_DIRECT_MODE;
   873		indio_dev->channels = vf610_adc_iio_channels;
 > 874		indio_dev->num_channels = (u32)device_get_match_data(dev);
   875	
   876		vf610_adc_cfg_init(info);
   877		vf610_adc_hw_init(info);
   878	
   879		ret = devm_iio_triggered_buffer_setup(&pdev->dev, indio_dev, &iio_pollfunc_store_time,
   880						      NULL, &iio_triggered_buffer_setup_ops);
   881		if (ret < 0)
   882			return dev_err_probe(&pdev->dev, ret, "Couldn't initialise the buffer\n");
   883	
   884		mutex_init(&info->lock);
   885	
   886		ret = devm_iio_device_register(&pdev->dev, indio_dev);
   887		if (ret)
   888			return dev_err_probe(&pdev->dev, ret, "Couldn't register the device.\n");
   889	
   890		return 0;
   891	}
   892	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki