[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241105140043.GF4507@kernel.org>
Date: Tue, 5 Nov 2024 14:00:43 +0000
From: Simon Horman <horms@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Jian Shen <shenjian15@...wei.com>,
Salil Mehta <salil.mehta@...wei.com>,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Jijie Shao <shaojijie@...wei.com>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: hisilicon: hns3: use ethtool string helpers
On Fri, Nov 01, 2024 at 03:00:23PM -0700, Rosen Penev wrote:
> The latter is the preferred way to copy ethtool strings.
>
> Avoids manually incrementing the pointer. Cleans up the code quite well.
>
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> Reviewed-by: Jijie Shao <shaojijie@...wei.com>
> Tested-by: Jijie Shao <shaojijie@...wei.com>
...
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> index 97eaeec1952b..b6cc51bfdd33 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> @@ -509,54 +509,38 @@ static int hns3_get_sset_count(struct net_device *netdev, int stringset)
> }
> }
>
> -static void *hns3_update_strings(u8 *data, const struct hns3_stats *stats,
> - u32 stat_count, u32 num_tqps, const char *prefix)
> +static void hns3_update_strings(u8 **data, const struct hns3_stats *stats,
> + u32 stat_count, u32 num_tqps,
> + const char *prefix)
> {
> #define MAX_PREFIX_SIZE (6 + 4)
Hi Rosen,
As per Jakub's feedback on v1, can't this #define be removed?
...
Powered by blists - more mailing lists