linux-kernel - Re: [PATCH] dt-bindings: can: convert tcan4x5x.txt to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afb3ebac-4099-42f3-b323-dd6a1555db7a@kernel.org>
Date: Tue, 5 Nov 2024 15:03:27 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sean Nyekjaer <sean@...nix.com>, Marc Kleine-Budde <mkl@...gutronix.de>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: can: convert tcan4x5x.txt to DT schema

On 05/11/2024 13:59, Sean Nyekjaer wrote:
> On Tue, Nov 05, 2024 at 01:41:26PM +0100, Krzysztof Kozlowski wrote:
> 
> NOW I get it :)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/ti,tcan4x5x.yaml b/Documentation/devicetree/bindings/net/can/ti,tcan4x5x.yaml
> index f1d18a5461e0..4fb5e5e80a03 100644
> --- a/Documentation/devicetree/bindings/net/can/ti,tcan4x5x.yaml
> +++ b/Documentation/devicetree/bindings/net/can/ti,tcan4x5x.yaml
> @@ -169,7 +169,7 @@ examples:
>          #size-cells = <0>;
> 
>          can@0 {
> -            compatible = "ti,tcan4552", "ti,tcan4x5x";
> +            compatible = "ti,tcan4552";
>              reg = <0>;
>              clocks = <&can0_osc>;
>              pinctrl-names = "default";
> 
> Would result in a schema check fail, but the driver will never be probed.
> 
>>

Yeah, but we dont' talk about this case.

>>> Agree that is kinda broken.
>>> If I have time I can try to fix that later.
>>
>> No, the fix is to drop the wildcard alone, as I said in your RFC.
> 
> @Mark, would you be okay with fixing the wildcard in this series?
> We have some out-of-tree dtb's that will need fixing, but I get it would be
> prefered to get this fixed.

Out of tree DTB will not need any fixes per-se. They will work 100%
fine. They will however report dtbs_check warnings, but before there was
no DT schema validation for them, so you replace one warning into
another warning.

You can of course improve out of tree users by dropping all warnings,
but that's kind of optional. The point is that nothing gets worse.

> 
>>
>>>
>>> Please explain one more time for me. Is this a comment on the if
>>> sentence or the broken behavior of the driver?
>>
>> This is just generic comment, nothing to change here because you decided
>> not to fix that wildcard from old binding.
> 
> Thanks for the clarification!
> 
> @Mark, @Krzysztof: What to do from here?

I will give Rb tag for next version fixing commented issues regardless
whether you drop usage of the wildcard-like 4x5x compatible alone. IOW,
I will be fine with pure conversion and keeping 4x5x, even though I
would prefer to improve the binding based on arguments before: there
will be no changes needed for in-kernel users, no out-of-tree users will
be affected, no breakage and using wildcard compatible alone is
discouraged. Sometimes strongly discouraged, depending on the case.

Best regards,
Krzysztof