linux-kernel - Re: [PATCH] [v3]USB: serial: qcserial: add support for Sierra Wireless EM86xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zyt52y7uc3u99p2V@hovoldconsulting.com>
Date: Wed, 6 Nov 2024 15:14:51 +0100
From: Johan Hovold <johan@...nel.org>
To: wojackbb@...il.com
Cc: gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v3]USB: serial: qcserial: add support for Sierra
 Wireless EM86xx

On Wed, Nov 06, 2024 at 06:50:29PM +0800, wojackbb@...il.com wrote:
> From: Jack Wu <wojackbb@...il.com>
> 
> Add support for Sierra Wireless EM86xx with
> USB-id 0x1199:0x90e5 & 0x1199:0x90e4.

> 0x1199:0x90e4
> T:  Bus=03 Lev=01 Prnt=01 Port=05 Cnt=01 Dev#= 16 Spd=480  MxCh= 0
> D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=1199 ProdID=90e4 Rev= 0.00
> S:  Manufacturer=Sierra Wireless, Incorporated
> S:  SerialNumber=004403161882339
> C:* #Ifs= 1 Cfg#= 1 Atr=a0 MxPwr=  2mA
> I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=10 Driver=qcserial
> E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> ---
> v3 changes: the entries sorted by PID
> ---
> Signed-off-by: Jack Wu <wojackbb@...il.com>
> ---

Thanks for the update. Next time make sure you put the changelog here
after your SoB and the --- line.

As it currently stands you SoB is not included when I apply the patch.
I've fixed it up manually, but please remember this for your future
contributions.

Also, the patch revision typically goes inside the PATCH marker:

	[PATCH v3] USB: serial: ...

Johan