[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1d801e59-341d-4f2f-88ca-98277731bd83@roeck-us.net>
Date: Wed, 6 Nov 2024 06:57:11 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Yassine Oudjana <y.oudjana@...tonmail.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] watchdog: mediatek: Fix mtk_wdt_restart
On 11/6/24 02:47, Yassine Oudjana wrote:
> Clear the IRQ enable bit of WDT_MODE before asserting software reset
> in order to make TOPRGU issue a system reset signal instead of an IRQ.
>
> Fixes: a44a45536f7b ("watchdog: Add driver for Mediatek watchdog")
> Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> ---
> drivers/watchdog/mtk_wdt.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index c35f85ce8d69c..e2d7a57d6ea2e 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -225,9 +225,15 @@ static int mtk_wdt_restart(struct watchdog_device *wdt_dev,
> {
> struct mtk_wdt_dev *mtk_wdt = watchdog_get_drvdata(wdt_dev);
> void __iomem *wdt_base;
> + u32 reg;
>
> wdt_base = mtk_wdt->wdt_base;
>
> + /* Enable reset in order to issue a system reset instead of an IRQ */
> + reg = readl(wdt_base + WDT_MODE);
> + reg &= ~WDT_MODE_IRQ_EN;
> + writel(reg | WDT_MODE_KEY, wdt_base + WDT_MODE);
> +
> while (1) {
> writel(WDT_SWRST_KEY, wdt_base + WDT_SWRST);
> mdelay(5);
Powered by blists - more mailing lists