linux-kernel - Re: [PATCH 1/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_OaH9e=4xX=ZJ1yH__EMo6x2Kzh1ZdD2rU+KG5x=4b_4Q@mail.gmail.com>
Date: Wed, 6 Nov 2024 10:27:19 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Zicheng Qu <quzicheng@...wei.com>
Cc: harry.wentland@....com, sunpeng.li@....com, Rodrigo.Siqueira@....com, 
	alexander.deucher@....com, christian.koenig@....com, Xinhui.Pan@....com, 
	airlied@...il.com, simona@...ll.ch, Alvin.Lee2@....com, 
	chiahsuan.chung@....com, alex.hung@....com, wenjing.liu@....com, 
	Dillon.Varone@....com, george.shen@....com, mwen@...lia.com, yi-lchen@....com, 
	martin.leung@....com, yongqiang.sun@....com, tony.cheng@....com, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, tanghui20@...wei.com, zhangqiao22@...wei.com, 
	judy.chenhui@...wei.com
Subject: Re: [PATCH 1/2] drm/amd/display: Fix incorrect power gating
 configuration for DOMAIN10

On Wed, Nov 6, 2024 at 3:18 AM Zicheng Qu <quzicheng@...wei.com> wrote:
>
> The current implementation incorrectly updates DOMAIN10_PG_CONFIG with
> DOMAIN8_POWER_FORCEON, which is not the intended behavior. This patch
> corrects the power gating configuration by updating DOMAIN10_PG_CONFIG
> with DOMAIN10_POWER_FORCEON, preventing potential issues related to
> power management.

The bitfield is the same for both so there is no functional change.
This is just a cosmetic change to use the right bitfield macro.

Alex

>
> Fixes: 46825fcfbe16 ("drm/amd/display: avoid power gate domains that doesn't exist")
> Signed-off-by: Zicheng Qu <quzicheng@...wei.com>
> ---
>  drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
> index a80c08582932..67a77274d813 100644
> --- a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
> @@ -317,7 +317,7 @@ void dcn20_enable_power_gating_plane(
>         if (REG(DOMAIN8_PG_CONFIG))
>                 REG_UPDATE(DOMAIN8_PG_CONFIG, DOMAIN8_POWER_FORCEON, force_on);
>         if (REG(DOMAIN10_PG_CONFIG))
> -               REG_UPDATE(DOMAIN10_PG_CONFIG, DOMAIN8_POWER_FORCEON, force_on);
> +               REG_UPDATE(DOMAIN10_PG_CONFIG, DOMAIN10_POWER_FORCEON, force_on);
>
>         /* DPP0/1/2/3/4/5 */
>         REG_UPDATE(DOMAIN1_PG_CONFIG, DOMAIN1_POWER_FORCEON, force_on);
> --
> 2.34.1
>