[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e99cb4a5-eb75-4248-b9ac-db16ed3b4f38@roeck-us.net>
Date: Wed, 6 Nov 2024 07:39:50 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: wenliang <wenliang202407@....com>
Cc: jdelvare@...e.com, corbet@....net, linux-hwmon@...r.kernel.org,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] hwmon: (ina226) Add support for SY24655
On 11/6/24 07:05, wenliang wrote:
> SY24655: Support for current and voltage detection as well as
> power calculation.
>
> Signed-off-by: wenliang <wenliang202407@....com>
> ---
> @@ -668,6 +731,11 @@ static umode_t ina2xx_is_visible(const void *_data, enum hwmon_sensor_types type
> if (has_alerts)
> return 0444;
> break;
> + case hwmon_power_average:
> + if (has_power_average)
> + return 0444;
> + break;
> + return 0444;
That is quite obviously wrong. Again, I'll fix it up myself
while applying the patch.
Guenter
Powered by blists - more mailing lists