linux-kernel - Re: [PATCH v2] goldfish: Fix unused const variable 'goldfish_pipe_acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZyuR8blW8IScgNl-@smile.fi.intel.com>
Date: Wed, 6 Nov 2024 17:57:37 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Zeng Heng <zengheng4@...wei.com>
Cc: gregkh@...uxfoundation.org, quic_jjohnson@...cinc.com,
	jinqian@...roid.com, jia-cheng.hu@...el.com,
	u.kleine-koenig@...gutronix.de, alan@...ux.intel.com,
	linux-kernel@...r.kernel.org, bobo.shaobowang@...wei.com
Subject: Re: [PATCH v2] goldfish: Fix unused const variable
 'goldfish_pipe_acpi_match'

On Sat, Oct 26, 2024 at 03:01:50PM +0800, Zeng Heng wrote:
> Fix the following compilation warning:
> 
> drivers/platform/goldfish/goldfish_pipe.c:925:36: warning:
> ‘goldfish_pipe_acpi_match’ defined but not used
> [-Wunused-const-variable=]
>   925 | static const struct acpi_device_id goldfish_pipe_acpi_match[] = {
> 
> The complexity of config guards needed for ACPI_PTR() is not worthwhile
> for the small amount of saved data. So remove the use of ACPI_PTR instead
> and drop now unneeded linux/acpi.h include.

...

>  #include <linux/io.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/mm.h>
> -#include <linux/acpi.h>

Because header inclusions are unsorted, it's unclear if there is
mod_devicetable.h included. If not, you should replace acpi.h with
mod_devicetable.h.

>  #include <linux/bug.h>
>  #include "goldfish_pipe_qemu.h"

Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko