linux-kernel - Re: [PATCH v4 5/7] hwmon: (pmbus/core) clear faults after setting smbalert mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec18ced0-c113-4925-8096-3f776f0f11d9@roeck-us.net>
Date: Wed, 6 Nov 2024 08:03:29 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Jerome Brunet <jbrunet@...libre.com>
Cc: Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
	Patrick Rudolph <patrick.rudolph@...ements.com>,
	Naresh Solanki <naresh.solanki@...ements.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-i2c@...r.kernel.org
Subject: Re: [PATCH v4 5/7] hwmon: (pmbus/core) clear faults after setting
 smbalert mask

On Tue, Nov 05, 2024 at 06:58:42PM +0100, Jerome Brunet wrote:
> pmbus_write_smbalert_mask() ignores the errors if the chip can't set
> smbalert mask the standard way. It is not necessarily a problem for the irq
> support if the chip is otherwise properly setup but it may leave an
> uncleared fault behind.
> 
> pmbus_core will pick the fault on the next register_check(). The register
> check will fails regardless of the actual register support by the chip.
> 
> This leads to missing attributes or debugfs entries for chips that should
> provide them.
> 
> We cannot rely on register_check() as PMBUS_SMBALERT_MASK may be read-only.
> 
> Unconditionally clear the page fault after setting PMBUS_SMBALERT_MASK to
> avoid the problem.
> 
> Suggested-by: Guenter Roeck <linux@...ck-us.net>
> Fixes: 221819ca4c36 ("hwmon: (pmbus/core) Add interrupt support")
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>

Applied.

Thanks,
Guenter