linux-kernel - Re: [PATCH v1 1/2] dt-bindings: iio: adc: Add binding for Nuvoton NCT720x ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241106-humid-unwired-1d3fa1f50469@spud>
Date: Wed, 6 Nov 2024 16:13:03 +0000
From: Conor Dooley <conor@...nel.org>
To: Chanh Nguyen <chanh@...eremail.onmicrosoft.com>
Cc: Eason Yang <j2anfernee@...il.com>, avifishman70@...il.com,
	tmaimon77@...il.com, tali.perry1@...il.com, venture@...gle.com,
	yuenn@...gle.com, benjaminfair@...gle.com, jic23@...nel.org,
	lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, nuno.sa@...log.com, dlechner@...libre.com,
	javier.carrasco.cruz@...il.com, andy@...nel.org,
	marcelo.schmitt@...log.com, olivier.moysan@...s.st.com,
	mitrutzceclan@...il.com, matteomartelli3@...il.com,
	alisadariana@...il.com, joao.goncalves@...adex.com,
	marius.cristea@...rochip.com, mike.looijmans@...ic.nl,
	chanh@...amperecomputing.com, KWLIU@...oton.com,
	yhyang2@...oton.com, openbmc@...ts.ozlabs.org,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: iio: adc: Add binding for Nuvoton
 NCT720x ADCs

On Wed, Nov 06, 2024 at 11:58:06AM +0700, Chanh Nguyen wrote:
> 
> 
> On 06/11/2024 09:39, Eason Yang wrote:
> > This adds a binding specification for the Nuvoton NCT7201/NCT7202
> > family of ADCs.
> > 
> > Signed-off-by: Eason Yang <j2anfernee@...il.com>
> > ---
> >   .../bindings/iio/adc/nuvoton,nct720x.yaml     | 47 +++++++++++++++++++
> >   MAINTAINERS                                   |  1 +
> >   2 files changed, 48 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,nct720x.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nct720x.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct720x.yaml
> > new file mode 100644
> > index 000000000000..3052039af10e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct720x.yaml
> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/adc/nuvoton,nct720x.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nuvoton nct7202 and similar ADCs
> > +
> > +maintainers:
> > +  - Eason Yang <yhyang2@...oton.com>
> > +
> > +description: |
> > +   Family of ADCs with i2c interface.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - nuvoton,nct7201
> > +      - nuvoton,nct7202
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  read-vin-data-size:
> 
> Is it generic property or vendor property? I tried to find in the
> https://github.com/torvalds/linux/tree/master/Documentation/devicetree/bindings
> , but it seems this property hasn't been used on other devices.
> 
> If it is vendor property, then I think it should include a vendor prefix.
> For examples:
> 
> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/iio/adc/adi%2Cad7780.yaml#L50
> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/iio/adc/fsl%2Cvf610-adc.yaml#L42
> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/iio/adc/st%2Cstmpe-adc.yaml#L22

An explanation of why it cannot be determined from the compatible would
also be good. Two compatibles and two values makes me a little
suspicious!

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)