linux-kernel - Re: [PATCH] media: videobuf2-core: copy vb planes unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZyuhknpDgVLl39zL@google.com>
Date: Wed, 6 Nov 2024 09:04:18 -0800
From: William McVicker <willmcvicker@...gle.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: tfiga@...omium.org, m.szyprowski@...sung.com, mchehab@...nel.org,
	yunkec@...omium.org, hverkuil@...all.nl,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, andre.draszik@...aro.org,
	kernel-team@...roid.com, stable@...r.kernel.org
Subject: Re: [PATCH] media: videobuf2-core: copy vb planes unconditionally

Hi Tudor,

On 11/06/2024, Tudor Ambarus wrote:
> Copy the relevant data from userspace to the vb->planes unconditionally
> as it's possible some of the fields may have changed after the buffer
> has been validated.
> 
> Keep the dma_buf_put(planes[plane].dbuf) calls in the first
> `if (!reacquired)` case, in order to be close to the plane validation code
> where the buffers were got in the first place.
> 
> Cc: stable@...r.kernel.org
> Fixes: 95af7c00f35b ("media: videobuf2-core: release all planes first in __prepare_dmabuf()")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...aro.org>

Thanks for sending this fix! I have tested that this fixes the video playback
issues I was seeing on my Pixel 6 device. Feel free to include my

Tested-by: Will McVicker <willmcvicker@...gle.com>

Thanks!
--Will