linux-kernel - RE: [PATCH 22/31] ASoC: da7213: Populate max_register to regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OS9PR01MB12389111288DF75C0D5C2907AB7532@OS9PR01MB12389.jpnprd01.prod.outlook.com>
Date: Wed, 6 Nov 2024 17:19:35 +0000
From: Chris Paterson <Chris.Paterson2@...esas.com>
To: Claudiu.Beznea <claudiu.beznea@...on.dev>, Mark Brown <broonie@...nel.org>
CC: "geert+renesas@...der.be" <geert+renesas@...der.be>,
	"mturquette@...libre.com" <mturquette@...libre.com>, "sboyd@...nel.org"
	<sboyd@...nel.org>, "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, Biju Das
	<biju.das.jz@...renesas.com>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@...renesas.com>, "lgirdwood@...il.com"
	<lgirdwood@...il.com>, "magnus.damm@...il.com" <magnus.damm@...il.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"support.opensource@...semi.com" <support.opensource@...semi.com>,
	"perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.com" <tiwai@...e.com>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"Adam.Thomson.Opensource@...semi.com" <Adam.Thomson.Opensource@...semi.com>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, Claudiu Beznea
	<claudiu.beznea.uj@...renesas.com>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: RE: [PATCH 22/31] ASoC: da7213: Populate max_register to
 regmap_config

Hi Claudiu,

> From: Claudiu Beznea <claudiu.beznea@...on.dev>
> Sent: 06 November 2024 13:56
> 
> Hi, Mark,
> 
> On 06.11.2024 15:43, Mark Brown wrote:
> > On Wed, Nov 06, 2024 at 10:18:17AM +0200, Claudiu wrote:
> >> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> >>
> >> On the Renesas RZ/G3S SMARC Carrier II board having a DA7212 codec
> (using
> >> da7213 driver) connected to one SSIF-2 available on the Renesas RZ/G3S
> SoC
> >> it has been discovered that using the runtime PM API for suspend/resume
> >> (as will be proposed in the following commits) leads to the codec not
> >> being propertly initialized after resume. This is because w/o
> >> max_register populated to regmap_config the regcache_rbtree_sync()
> >> breaks on base_reg > max condition and the regcache_sync_block() call
> is
> >> skipped.
> >>
> >> Fixes: ef5c2eba2412 ("ASoC: codecs: Add da7213 codec")
> >> Cc: stable@...r.kernel.org
> >
> > Why is this a stable fix when it only enables further work?
> 
> I thought that not syncing the cached registers might impact other setups
> as well.
> 
> Also, Renesas is contributing to CIP (Civil Infrastructure Project) which
> is based on stable releases. The audio support in this series will be
> backported to CIP kernels. Marking it for stable ease the work to backport
> the RZ/G3S audio support to CIP.

Whilst the above is true, we still must adhere to the "stable" rules - Only bug fixes etc. should be marked for stable.
Any extra effort is for CIP to do.

As you say perhaps this patch will fix code functionality for other users.
I'll leave it to the relevant maintainers to decide if this is a suitable bug fix or not :)

Kind regards, Chris

> 
> With this, would you prefer to drop the "Cc: stable@...r.kernel.org"?
> 
> Thank you,
> Claudiu Beznea