linux-kernel - Re: [PATCH] Fix wrong max check in bch2_opt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <zfmodm3fg572yt3ef5zuf3dzc23234d5nrmtiuyxjquki2756w@yyt2fekeyfnr>
Date: Wed, 6 Nov 2024 14:34:20 -0500
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Piotr Zalewski <pZ010001011111@...ton.me>
Cc: linux-bcachefs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	skhan@...uxfoundation.org, syzbot+bee87a0c3291c06aa8c6@...kaller.appspotmail.com
Subject: Re: [PATCH] Fix wrong max check in bch2_opt_validate

On Wed, Nov 06, 2024 at 06:58:04PM +0000, Piotr Zalewski wrote:
> 
> 
> 
> 
> 
> Sent with Proton Mail secure email.
> 
> On Wednesday, November 6th, 2024 at 6:52 PM, Kent Overstreet <kent.overstreet@...ux.dev> wrote:
> 
> > On Wed, Nov 06, 2024 at 08:11:13AM +0000, Piotr Zalewski wrote:
> > 
> > > Hi Kent,
> > > 
> > > Did you see this?
> > 
> > 
> > Whoops, I did miss it the first time.
> 
> np
> 
> > I think it'd be better to fix it in the OPT_STR() macro though.
> 
> If changed in OPT_STR() macro it would also require a change in
> bch2_opt_to_text:434 (it also does -1 there).

*nod*

I think we should do it that way then, we don't want opt->max meaning
different things in different contexts if we can avoid it