linux-kernel - Re: [PATCH] arm: dts: aspeed: Everest and Fuji: Add VRM presence gpio expander

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a2f9268449b08a8e48e882bf1b1ce6f605fe3a0.camel@codeconstruct.com.au>
Date: Thu, 07 Nov 2024 09:59:26 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Eddie James <eajames@...ux.ibm.com>, linux-aspeed@...ts.ozlabs.org
Cc: joel@....id.au, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org,  devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: dts: aspeed: Everest and Fuji: Add VRM presence
 gpio expander

On Wed, 2024-11-06 at 13:33 -0600, Eddie James wrote:
> Add the gpio expander that provides the VRM presence detection
> pins.
> 
> Signed-off-by: Eddie James <eajames@...ux.ibm.com>
> ---
>  .../dts/aspeed/aspeed-bmc-ibm-everest.dts     | 27
> +++++++++++++++++++
>  .../boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts   | 27
> +++++++++++++++++++
>  2 files changed, 54 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> index 513077a1f4be..9961508ee872 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> @@ -353,6 +353,33 @@ pca1: pca9552@62 {
>                         "presence-base-op",
>                         "";
>         };
> +
> +       led-controller@63 {
> +               compatible = "nxp,pca9552";

So Lee has queued the binding for the pca9552 in the leds tree[1], and
I've applied the patch on that basis.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/commit/?h=for-leds-next&id=f92d2e9334171d07b47189397f222f64dcb77617

However, when merging for-leds-next into a tree with your patch here to
test, it surfaced a bunch of further (unrelated) issues:

    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@65: 'led@10', 'led@11' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@31: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@32: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@33: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@30: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@34: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@35: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@60: 'led@10', 'led@11', 'led@12', 'led@13' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#

Can you please send a follow-up patch resolving those and any similar
warnings for Fuji?

Thanks

Andrew