linux-kernel - RE: [PATCH v2 1/2] jiffies: Define secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874j4jq5nq.ffs@tglx>
Date: Thu, 07 Nov 2024 00:55:05 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: David Laight <David.Laight@...LAB.COM>, Geert Uytterhoeven
 <geert@...ux-m68k.org>
Cc: Easwar Hariharan <eahariha@...ux.microsoft.com>, "K. Y. Srinivasan"
 <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu
 <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
 "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, Anna-Maria
 Behnsen <anna-maria@...utronix.de>, Marcel Holtmann <marcel@...tmann.org>,
 Johan Hedberg <johan.hedberg@...il.com>, Luiz Augusto von Dentz
 <luiz.dentz@...il.com>, "linux-bluetooth@...r.kernel.org"
 <linux-bluetooth@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, Michael Kelley <mhklinux@...look.com>
Subject: RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

On Wed, Nov 06 2024 at 22:19, David Laight wrote:
> From: Thomas Gleixner
>> Still the macro should be documented.
>
> I was wondering if it really had any purpose at all.
> It just obfuscates code, doesn't even make it smaller.

What is obfuscated here?

secs_to_jiffies() is clearly describing what this is about, while 5 * HZ
is not. Nothing in a driver has to care about the underlying conversion
of a time delta expressed in SI units to a jiffies based time delta.

Thanks,

        tglx