linux-kernel - Re: [PATCH] Use strscpy() instead of the deprecated strlcpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGiJo8RyjXdgNqyPNhZFJ_5oH0z1RWeXnM6RGnq65KCDbyp6DQ@mail.gmail.com>
Date: Tue, 5 Nov 2024 16:29:25 -0800
From: Daniel Yang <danielyangkang@...il.com>
To: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, 
	"Liang, Kan" <kan.liang@...ux.intel.com>, 
	"open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-perf-users@...r.kernel.org>, 
	"open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Use strscpy() instead of the deprecated strlcpy()

On Tue, Nov 5, 2024 at 4:25 AM Athira Rajeev
<atrajeev@...ux.vnet.ibm.com> wrote:
> Hi,
>
> This hits a compilation fail:

Oh I see. Apologies, I thought compiling the kernel also compiled the
tools directory so I didn't get any compilation errors.

> So the strscpy here is defined as strcpy itself.
>
> Ian discussed about having an strscpy shim for perf here :
> https://lore.kernel.org/linux-perf-users/172892779710.897882.14949543082561189584.b4-ty@kernel.org/T/#meaa2f8d993c6db435f9ed399dc1bf10132a31292
>
> So IIUC, we are yet to have the safe strscpy in the tools perf.

Is there any issue with just porting over the kernel code?

- Daniel