linux-kernel - Re: [PATCH stable 6.11.y] netfs: reset subreq->iov_iter before netfs_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024110644-audible-canine-30ca@gregkh>
Date: Wed, 6 Nov 2024 06:59:03 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Christian Ebner <c.ebner@...xmox.com>
Cc: dhowells@...hat.com, jlayton@...nel.org, stable@...r.kernel.org,
	netfs@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH stable 6.11.y] netfs: reset subreq->iov_iter before
 netfs_clear_unread() tail clean

On Sun, Oct 27, 2024 at 12:43:15PM +0100, Christian Ebner wrote:
> Fixes file corruption issues when reading contents via ceph client.
> 
> Call netfs_reset_subreq_iter() to align subreq->io_iter before
> calling netfs_clear_unread() to clear tail, as subreq->io_iter count
> and subreq->transferred might not be aligned after incomplete I/O,
> having the subreq's NETFS_SREQ_CLEAR_TAIL set.
> 
> Based on ee4cdf7b ("netfs: Speed up buffered reading"), which
> introduces a fix for the issue in mainline.
> 
> Fixes: 92b6cc5d ("netfs: Add iov_iters to (sub)requests to describe various buffers")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219237
> Signed-off-by: Christian Ebner <c.ebner@...xmox.com>
> ---
> Sending this patch in an attempt to backport the fix introduced by
> commit ee4cdf7b ("netfs: Speed up buffered reading"), which however
> can not be cherry picked for older kernels, as the patch is not
> independent from other commits and touches a lot of unrelated (to
> the fix) code.

We would much rather take the original series of commits, what exactly
are they here?

thanks,

greg k-h