linux-kernel - RE: [PATCH v2] PCI: dwc: Fix resume failure if no EP is connected at some platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB8676B83C73ABBA45A34C58DB8C532@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date: Wed, 6 Nov 2024 06:18:24 +0000
From: Hongxing Zhu <hongxing.zhu@....com>
To: Krzysztof Wilczy��ski <kwilczynski@...nel.org>
CC: "bhelgaas@...gle.com" <bhelgaas@...gle.com>, "lorenzo.pieralisi@....com"
	<lorenzo.pieralisi@....com>, Frank Li <frank.li@....com>, "mani@...nel.org"
	<mani@...nel.org>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH v2] PCI: dwc: Fix resume failure if no EP is connected at
 some platforms

> -----Original Message-----
> From: Krzysztof Wilczy��ski <kwilczynski@...nel.org>
> Sent: 2024年11月4日 4:57
> To: Hongxing Zhu <hongxing.zhu@....com>
> Cc: bhelgaas@...gle.com; lorenzo.pieralisi@....com; Frank Li
> <frank.li@....com>; mani@...nel.org; linux-pci@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> kernel@...gutronix.de; imx@...ts.linux.dev
> Subject: Re: [PATCH v2] PCI: dwc: Fix resume failure if no EP is connected at
> some platforms
>
> Hello,
>
> > The dw_pcie_suspend_noirq() function currently returns success
> > directly if no endpoint (EP) device is connected. However, on some
> > platforms, power loss occurs during suspend, causing dw_resume() to do
> nothing in this case.
> > This results in a system halt because the DWC controller is not
> > initialized after power-on during resume.
> >
> > Change call to deinit() in suspend and init() at resume regardless of
> > whether there are EP device connections or not. It is not harmful to
> > perform deinit() and init() again for the no power-off case, and it
> > keeps the code simple and consistent in logic.
>
> Applied to controller/dwc, thank you!
>
> [01/01] PCI: dwc: Fix resume failure if no EP is connected at some platforms

Hi Krzysztof:
Thanks for your pick up.
I combine this dwc bug fix with the other one.
Can you help to replace this commit by the following series?
https://lkml.org/lkml/2024/10/10/240

Best Regards
Richard Zhu

>
> https://git.ker/
> nel.org%2Fpci%2Fpci%2Fc%2Fec008c493c25&data=05%7C02%7Chongxing.z
> hu%40nxp.com%7C99612c264e704deef3f508dcfc4a1205%7C686ea1d3bc2b
> 4c6fa92cd99c5c301635%7C0%7C0%7C638662642267419531%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=rlIjV2gZWnnruUR8DynTqyU
> vnO%2B%2BxvzxiCDw%2FneoQMw%3D&reserved=0
>
>       Krzysztof