linux-kernel - Re: [PATCH v2 3/3] docs: submitting-patches: Describe the use of Helped-by tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33204d0882909375801a2b0c74b5354c@manjaro.org>
Date: Wed, 06 Nov 2024 07:47:01 +0100
From: Dragan Simic <dsimic@...jaro.org>
To: apw@...onical.com, joe@...ches.com, corbet@....net
Cc: dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
 workflows@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, wens@...e.org
Subject: Re: [PATCH v2 3/3] docs: submitting-patches: Describe the use of
 Helped-by tag

Hello,

On 2024-11-06 07:28, Dragan Simic wrote:
> Add the description of the intended use of Helped-by tags, which give 
> credit
> to the persons who assisted the patch authors in a way that didn't 
> actually
> contribute to the patch directly, i.e. at the source-code level.
> 
> Suggested-by: Chen-Yu Tsai <wens@...e.org>
> Signed-off-by: Dragan Simic <dsimic@...jaro.org>
> ---
>  Documentation/process/submitting-patches.rst | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/process/submitting-patches.rst
> b/Documentation/process/submitting-patches.rst
> index 382c49659cb9..d0d12536ab68 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -452,8 +452,8 @@ as it was propagated to the maintainers and
> ultimately to Linus, with
>  the first SoB entry signalling primary authorship of a single author.
> 
> 
> -When to use Acked-by:, Cc:, and Co-developed-by:
> -------------------------------------------------
> +When to use Acked-by:, Cc:, Co-developed-by:, and Helped-by
> +-----------------------------------------------------------

Oh, now I see that I've missed a colon after Helped-by in the section
title above. :/  Would you like me to send a v3 with the fix, or do you
prefer to fix it by hand before applying the patch?

>  The Signed-off-by: tag indicates that the signer was involved in the
>  development of the patch, or that he/she was in the patch's delivery 
> path.
> @@ -495,6 +495,14 @@ chronological history of the patch insofar as
> possible, regardless of whether
>  the author is attributed via From: or Co-developed-by:.  Notably, the 
> last
>  Signed-off-by: must always be that of the developer submitting the 
> patch.
> 
> +Helped-by: gives attribution to the persons that helped the patch 
> authors
> +in a way that didn't directly produce the patch itself.  For example, 
> someone
> +may provide significant assistance to the authors by researching the 
> schematic
> +of a device that the patch addresses, or by providing the patch 
> authors with
> +some background information required to develop the patch, while 
> contributing
> +no actual source code.  As a result of no direct patch authorship, no
> +Signed-off-by: tags are needed together with Helped-by: tags.
> +
>  Note, the From: tag is optional when the From: author is also the 
> person (and
>  email) listed in the From: line of the email header.