linux-kernel - Re: [PATCH] ALSA: compress_offload: Remove unused runtime pointer from snd_compr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b26086ef-07b4-4013-97d8-6a8ff151d42c@linux.intel.com>
Date: Wed, 6 Nov 2024 09:49:00 +0200
From: Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>
To: vkoul@...nel.org, perex@...ex.cz, tiwai@...e.com
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 broonie@...nel.org, amadeuszx.slawinski@...ux.intel.com
Subject: Re: [PATCH] ALSA: compress_offload: Remove unused runtime pointer
 from snd_compr_poll()



On 06/11/2024 09:06, Peter Ujfalusi wrote:
> runtime is not used as seen with W=1 :
> sound/core/compress_offload.c: In function ‘snd_compr_poll’:
> sound/core/compress_offload.c:409:35: error: variable ‘runtime’ set but not used [-Werror=unused-but-set-variable]
>   409 |         struct snd_compr_runtime *runtime;
>       |                                   ^~~~~~~
> 
> Fixes: 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>
> ---
>  sound/core/compress_offload.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 5ecdad80a0d8..c08afbd0155b 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -406,7 +406,6 @@ static __poll_t snd_compr_poll(struct file *f, poll_table *wait)
>  {
>  	struct snd_compr_file *data = f->private_data;
>  	struct snd_compr_stream *stream;
> -	struct snd_compr_runtime *runtime;
>  	size_t avail;
>  	__poll_t retval = 0;
>  
> @@ -414,8 +413,6 @@ static __poll_t snd_compr_poll(struct file *f, poll_table *wait)
>  		return EPOLLERR;
>  
>  	stream = &data->stream;
> -	runtime = stream->runtime;
> -

Probably it would be better to _use_ the runtime in the rest of the
function. Please ignore this patch, I will send a new one.

>  	guard(mutex)(&stream->device->lock);
>  
>  	switch (stream->runtime->state) {

-- 
Péter