linux-kernel - Re: (subset) [PATCH v2] leds: introduce ordered workqueue for leds events instead of system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241106081239.GF1807686@google.com>
Date: Wed, 6 Nov 2024 08:12:39 +0000
From: Lee Jones <lee@...nel.org>
To: pavel@....cz, Dmitry Rokosov <ddrokosov@...utedevices.com>
Cc: linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
	kernel@...utedevices.com, rockosov@...il.com,
	Alexey Romanov <avromanov@...utedevices.com>
Subject: Re: (subset) [PATCH v2] leds: introduce ordered workqueue for leds
 events instead of system_wq

On Wed, 06 Nov 2024, Lee Jones wrote:

> On Wed, 04 Sep 2024 01:39:30 +0300, Dmitry Rokosov wrote:
> > This allows to setup ordered workqueue for leds events. This may be
> > useful, because default 'system_wq' does not guarantee execution order
> > of each work_struct, thus for several brightness update requests (for
> > multiple leds), real brightness switch could be in random order.
> > 
> > Yes, for sysfs-based leds we have flush_work() call inside
> > brightness_store() operation, but it's blocking call, so userspace
> > caller can be blocked at a long time, which means leds animation stream
> > can be broken.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] leds: introduce ordered workqueue for leds events instead of system_wq
>       commit: 32360bf6a5d4016669c3545e7b0ec939937f5331

With a couple of style fix-ups.

-- 
Lee Jones [李琼斯]