linux-kernel - Re: [PATCH] ALSA: compress_offload: Use runtime pointer in snd_compr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <553f9a5c-9d98-46bf-b0e5-6a9a49231104@perex.cz>
Date: Wed, 6 Nov 2024 09:19:10 +0100
From: Jaroslav Kysela <perex@...ex.cz>
To: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>, vkoul@...nel.org,
 tiwai@...e.com
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 broonie@...nel.org, amadeuszx.slawinski@...ux.intel.com
Subject: Re: [PATCH] ALSA: compress_offload: Use runtime pointer in
 snd_compr_poll()

On 06. 11. 24 8:53, Peter Ujfalusi wrote:
> runtime is not used as seen with W=1 :
> sound/core/compress_offload.c: In function ‘snd_compr_poll’:
> sound/core/compress_offload.c:409:35: error: variable ‘runtime’ set but not used [-Werror=unused-but-set-variable]
>    409 |         struct snd_compr_runtime *runtime;
>        |                                   ^~~~~~~
> 
> Instead of dropping the runtime, use it in the function in place of
> stream->runtime

Yes, it was the desired target for this change. Unfortunately unfinished. Thanks.

Reviewed-by: Jaroslav Kysela <perex@...ex.cz>

-- 
Jaroslav Kysela <perex@...ex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.