linux-kernel - Re: [PATCH v3 1/2] KVM: x86: Check hypercall's exit to userspace generically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2c19b20b11c307cc6b4ae47cd7f891e690b419b.camel@intel.com>
Date: Wed, 6 Nov 2024 08:54:22 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "seanjc@...gle.com" <seanjc@...gle.com>, "binbin.wu@...ux.intel.com"
	<binbin.wu@...ux.intel.com>
CC: "Li, Xiaoyao" <xiaoyao.li@...el.com>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, "pbonzini@...hat.com" <pbonzini@...hat.com>,
	"yuan.yao@...ux.intel.com" <yuan.yao@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Edgecombe,
 Rick P" <rick.p.edgecombe@...el.com>, "Yamahata, Isaku"
	<isaku.yamahata@...el.com>
Subject: Re: [PATCH v3 1/2] KVM: x86: Check hypercall's exit to userspace
 generically

On Wed, 2024-11-06 at 16:32 +0800, Binbin Wu wrote:
> > static void kvm_complete_hypercall_exit(struct kvm_vcpu *vcpu, int ret_reg,
> >  				        unsigned long ret, bool op_64_bit)
> > {
> >  	if (!op_64_bit)
> >  		ret = (u32)ret;
> >  	kvm_register_write_raw(vcpu, ret_reg, ret);
> >  	++vcpu->stat.hypercalls;
> > }
> If this is going to be the final version, it would be better to make it
> public, and export the symbol, so that TDX code can reuse it.

Does making it 'static inline' and moving to kvm_host.h work?

kvm_register_write_raw(), and kvm_register_mark_dirty() which is called by
kvm_register_write_raw()), are both 'static inline'.  Seems we can get rid of
export by making it 'static inline'.