linux-kernel - Re: [PATCH v2] uprobes: Improve the usage of xol slots for better scalability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bcc6d5b-08d6-48a8-99d2-d8bb2bef2d6c@huawei.com>
Date: Wed, 6 Nov 2024 17:12:36 +0800
From: "Liao, Chang" <liaochang1@...wei.com>
To: <andrii@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>,
	<linux-perf-users@...r.kernel.org>, <bpf@...r.kernel.org>, Mark Rutland
	<mark.rutland@....com>, Peter Zijlstra <peterz@...radead.org>, Oleg Nesterov
	<oleg@...hat.com>, Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH v2] uprobes: Improve the usage of xol slots for better
 scalability

在 2024/9/27 17:45, Liao Chang 写道:
>>  2 files changed, 139 insertions(+), 42 deletions(-)
>>
> Liao,
> 
> Assuming your ARM64 improvements go through, would you still need
> these changes? XOL case is a slow case and if possible should be
> avoided at all costs. If all common cases for ARM64 are covered
> through instruction emulation, would we need to add all this
> complexity to optimize slow case?

Andrii,

I've studied the optimizations merged over the past month, it seems
that part of the problem addressed in this patch has been resolved
by Oleg(uprobes: kill xol_area->slot_count). And I hope you've received
the email with the re-run results for -push using simulated STP on
the latest kernel (tag next-20241104). It show significant improvements,
althought there's still room to match the throughput of -nop and -ret.
So based on these results, I would prioritize the STP simulation patch.

-- 
BR
Liao, Chang