linux-kernel - Re: [PATCH] net: qrtr: mhi: synchronize qrtr and mhi preparation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1314b8d9-c0cb-4d48-b7a6-1ac56ab7193c@inbox.ru>
Date: Wed, 6 Nov 2024 12:14:47 +0300
From: Maxim Kochetkov <fido_max@...ox.ru>
To: Chris Lew <quic_clew@...cinc.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Hemant Kumar <quic_hemantk@...cinc.com>,
 Loic Poulain <loic.poulain@...aro.org>
Cc: Manivannan Sadhasivam <mani@...nel.org>,
 Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
 linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Bhaumik Bhatt <bbhatt@...eaurora.org>,
 Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH] net: qrtr: mhi: synchronize qrtr and mhi preparation

05.11.2024 04:29, Chris Lew wrote:
> From: Bhaumik Bhatt <bbhatt@...eaurora.org>
> 
> The call to qrtr_endpoint_register() was moved before
> mhi_prepare_for_transfer_autoqueue() to prevent a case where a dl
> callback can occur before the qrtr endpoint is registered.
> 
> Now the reverse can happen where qrtr will try to send a packet
> before the channels are prepared. Add a wait in the sending path to
> ensure the channels are prepared before trying to do a ul transfer.
> 
> Fixes: 68a838b84eff ("net: qrtr: start MHI channel after endpoit creation")
> Reported-by: Johan Hovold <johan@...nel.org>
> Closes: https://lore.kernel.org/linux-arm-msm/ZyTtVdkCCES0lkl4@hovoldconsulting.com/
> Signed-off-by: Bhaumik Bhatt <bbhatt@...eaurora.org>
> Signed-off-by: Chris Lew <quic_clew@...cinc.com>

Reviewed-by: Maxim Kochetkov <fido_max@...ox.ru>