linux-kernel - Re: [PATCH 08/21] dt-bindings: gpu: img: Add BXS-4-64 devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd3d9f34-0e8f-44a1-ac21-2ee0c49d65fa@imgtec.com>
Date: Wed, 6 Nov 2024 10:18:10 +0000
From: Matt Coster <Matt.Coster@...tec.com>
To: Conor Dooley <conor@...nel.org>
CC: Frank Binns <Frank.Binns@...tec.com>, David Airlie <airlied@...il.com>,
        Simona Vetter <simona@...ll.ch>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero
 Kristo <kristo@...nel.org>,
        "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        Randolph Sapp <rs@...com>, Darren
 Etheridge <detheridge@...com>
Subject: Re: [PATCH 08/21] dt-bindings: gpu: img: Add BXS-4-64 devicetree
 bindings

On 05/11/2024 18:03, Conor Dooley wrote:
> On Tue, Nov 05, 2024 at 03:58:14PM +0000, Matt Coster wrote:
>> +    / {
>> +        #address-cells = <2>;
>> +        #size-cells = <2>;
>> +        interrupt-controller;
>> +        #interrupt-cells = <3>;
>> +
>> +        gpu@...0000000 {
>> +            compatible = "ti,j721s2-gpu", "img,img-bxs-4-64", "img,img-rogue";
>> +            reg = /bits/ 64 <0x4e20000000 0x80000>;
> 
> Can you format this normally please? Drop the #address/size-cells down
> to 1 if you're against having 0x0s.

Sure. I thought /bits/ was the "new" way of doing things, but I'm not
really bothered either way.

Cheers,
Matt

> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> 
>> +            clocks = <&k3_clks 130 1>;
>> +            clock-names = "core";
>> +            interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
>> +            power-domains = <&k3_pds 130 TI_SCI_PD_EXCLUSIVE>,
>> +                            <&k3_pds 373 TI_SCI_PD_EXCLUSIVE>;
>> +            power-domain-names = "a", "b";
>> +            dma-coherent;
>> +        };
>> +    };
>>
>> -- 
>> 2.47.0
>>

-- 
Matt Coster
E: matt.coster@...tec.com


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)