linux-kernel - Re: FAILED: Patch "ALSA: hda/realtek: Fix headset mic on TUXEDO Gemini 17 Gen3" failed to apply to v6.1-stable tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d71bdeaf-b137-4826-8926-da9da1904232@tuxedocomputers.com>
Date: Wed, 6 Nov 2024 13:08:36 +0100
From: Werner Sembach <wse@...edocomputers.com>
To: Sasha Levin <sashal@...nel.org>
Cc: stable@...r.kernel.org, cs@...edo.de, Takashi Iwai <tiwai@...e.de>,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: FAILED: Patch "ALSA: hda/realtek: Fix headset mic on TUXEDO
 Gemini 17 Gen3" failed to apply to v6.1-stable tree

Hi,

Am 06.11.24 um 13:00 schrieb Sasha Levin:
> On Wed, Nov 06, 2024 at 10:23:14AM +0100, Werner Sembach wrote:
>> Am 06.11.24 um 10:19 schrieb Werner Sembach:
>>> Hi,
>>>
>>> Am 06.11.24 um 03:11 schrieb Sasha Levin:
>>>> The patch below does not apply to the v6.1-stable tree.
>>>> If someone wants it applied there, or to any other stable or longterm
>>>> tree, then please email the backport, including the original git commit
>>>> id to <stable@...r.kernel.org>.
>>>
>>> Applying 33affa7fb46c0c07f6c49d4ddac9dd436715064c (ALSA: hda/realtek: Add 
>>> quirks for some Clevo laptops) first and then 
>>> 0b04fbe886b4274c8e5855011233aaa69fec6e75 (ALSA: hda/realtek: Fix headset mic 
>>> on TUXEDO Gemini 17 Gen3) and e49370d769e71456db3fbd982e95bab8c69f73e8 
>>> (ALSA: hda/realtek: Fix headset mic on TUXEDO Stellaris 16 Gen6 mb1) makes 
>>> everything work without alteration.
>>>
>>> The first one is just missing the cc stable tag, probably by accident.
>>>
>>> Should I alter the 2nd and 3rd commit or should I send a patchset that 
>>> includes the first one?
>>
>> Sorry just realized that for 5.15 it's a different patch that is missing for 
>> e49370d769e71456db3fbd982e95bab8c69f73e8 to cleanly apply
>>
>> I will just alter the patches
>
> It applies, but fails to build:
>
> In file included from sound/pci/hda/patch_realtek.c:21:
> sound/pci/hda/patch_realtek.c:9530:59: error: 'ALC2XX_FIXUP_HEADSET_MIC' 
> undeclared here (not in a function); did you mean 'ALC283_FIXUP_HEADSET_MIC'?
>  9530 |         SND_PCI_QUIRK(0x1d05, 0x1387, "TongFang GMxIXxx", 
> ALC2XX_FIXUP_HEADSET_MIC),
>       | ^~~~~~~~~~~~~~~~~~~~~~~~
> ./include/sound/core.h:465:50: note: in definition of macro 'SND_PCI_QUIRK'
>   465 |         {_SND_PCI_QUIRK_ID(vend, dev), .value = (val), .name = (xname)}
>       |                                                  ^~~
> make[3]: *** [scripts/Makefile.build:289: sound/pci/hda/patch_realtek.o] Error 1
>
I'm sorry I did not double check if the define exists ins 6.1.

Considering that it's a fairly new device it's reasonable enough to assume that 
it's probably not run with the 6.1 kernel and so I don't want to blow up the 
patch to much. So just forget about it and sorry again that I caused you extra work.

Kind regards,

Werner Sembach