linux-kernel - Re: [PATCH] pcmcia: omap_cf: : Mark driver struct with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVkMezR+opdwY=8QQuKRsniMhP3D6EiHVycn69PRUuPeg@mail.gmail.com>
Date: Wed, 6 Nov 2024 13:51:41 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Uwe Kleine-König <ukleinek@...nel.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>
Cc: Dominik Brodowski <linux@...inikbrodowski.net>, Aaro Koskinen <aaro.koskinen@....fi>, 
	Janusz Krzysztofik <jmkrzyszt@...il.com>, Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] pcmcia: omap_cf: : Mark driver struct with __refdata to
 prevent section mismatch

On Wed, Nov 6, 2024 at 1:14 PM Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
> As described in the added code comment, a reference to .exit.text is ok
> for drivers registered via platform_driver_probe().  Make this explicit
> to prevent the following section mismatch warning
>
>     WARNING: modpost: drivers/pcmcia/omap_cf: section mismatch in reference: omap_cf_driver+0x4 (section: .data) -> omap_cf_remove (section: .exit.text)
>
> that triggers on an omap1_defconfig + CONFIG_OMAP_CF=m build.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

There is one more in the DaVinci cpufreq driver, but that one never
triggers a warning, as it cannot be a module.

So either davinci_cpufreq_remove() should be removed (it is never
emitted), or the __exit and __exit_p() should be dropped (then it can
be unbound manually, but never rebound).

https://elixir.bootlin.com/linux/v6.11.6/source/drivers/cpufreq/davinci-cpufreq.c#L134

Thoughts?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds