linux-kernel - Re: [PATCH] char:ipmi: Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZytoWGTQ4fn9KpV2@mail.minyard.net>
Date: Wed, 6 Nov 2024 07:00:08 -0600
From: Corey Minyard <corey@...yard.net>
To: liujing <liujing@...s.chinamobile.com>
Cc: minyard@....org, openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char:ipmi: Fix the wrong format specifier

On Wed, Nov 06, 2024 at 07:14:58PM +0800, liujing wrote:
> Because the types of io.regsize and io.regspacing in the ipmipci_probe function are unsigned int,
> they should be output in the %u format.

I reformatted the above text to fit into 80 characters, but this is
right, I've applied it.

-corey

> 
> Signed-off-by: liujing <liujing@...s.chinamobile.com>
> 
> diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c
> index b83d55685b22..8c0ea637aba0 100644
> --- a/drivers/char/ipmi/ipmi_si_pci.c
> +++ b/drivers/char/ipmi/ipmi_si_pci.c
> @@ -118,7 +118,7 @@ static int ipmi_pci_probe(struct pci_dev *pdev,
>  	if (io.irq)
>  		io.irq_setup = ipmi_std_irq_setup;
>  
> -	dev_info(&pdev->dev, "%pR regsize %d spacing %d irq %d\n",
> +	dev_info(&pdev->dev, "%pR regsize %u spacing %u irq %d\n",
>  		 &pdev->resource[0], io.regsize, io.regspacing, io.irq);
>  
>  	return ipmi_si_add_smi(&io);
> -- 
> 2.27.0
> 
> 
>