linux-kernel - Re: [Intel-wired-lan] [PATCH v4 net-next 1/4] igc: Fix passing 0 to ERR_PTR in igc_xdp_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc46b503-df05-6c33-9246-870cff7ad233@intel.com>
Date: Wed, 6 Nov 2024 15:22:09 +0200
From: Avigail Dahan <Avigailx.dahan@...el.com>
To: Yue Haibing <yuehaibing@...wei.com>, <anthony.l.nguyen@...el.com>,
	<przemyslaw.kitszel@...el.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <ast@...nel.org>,
	<daniel@...earbox.net>, <hawk@...nel.org>, <john.fastabend@...il.com>,
	<maciej.fijalkowski@...el.com>, <vedang.patel@...el.com>,
	<jithu.joseph@...el.com>, <andre.guedes@...el.com>, <horms@...nel.org>,
	<jacob.e.keller@...el.com>, <sven.auhagen@...eatech.de>,
	<alexander.h.duyck@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <bpf@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH v4 net-next 1/4] igc: Fix passing 0 to
 ERR_PTR in igc_xdp_run_prog()



On 26/10/2024 7:12, Yue Haibing wrote:
> igc_xdp_run_prog() converts customed xdp action to a negative error code
> with the sk_buff pointer type which be checked with IS_ERR in
> igc_clean_rx_irq(). Remove this error pointer handing instead use plain
> int return value to fix this smatch warnings:
> 
> drivers/net/ethernet/intel/igc/igc_main.c:2533
>   igc_xdp_run_prog() warn: passing zero to 'ERR_PTR'
> 
> Fixes: 26575105d6ed ("igc: Add initial XDP support")
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 20 +++++++-------------
>   1 file changed, 7 insertions(+), 13 deletions(-)
> 
Tested-by: Avigail Dahan <avigailx.dahan@...el.com>